Use https for all content #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades the pixel to use https, which in turn eliminates the insecure content warnings on pytorch.org
JoelMarcey
approved these changes
Mar 26, 2019
|
Deploy preview for pytorch-dot-org-preview ready! Built with commit e02660d https://deploy-preview-177--pytorch-dot-org-preview.netlify.com |
|
Note that this doesn't actually update all of the old pages. I think we need to either manually codemod and/or regenerate from sphinx. |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 27, 2019
Summary: There are a number of pages in the docs that serve insecure content. AFAICT this is the sole source of that. I wasn't sure if docs get regenerated for old versions as part of the automation, or if those would need to be manually done. cf. pytorch/pytorch.github.io#177 Pull Request resolved: #18508 Differential Revision: D14645665 Pulled By: zpao fbshipit-source-id: 003563b06048485d4f539feb1675fc80bab47c1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the pixel to use https, which in turn eliminates the
insecure content warnings on pytorch.org